Dateien hochladen nach „“

Live recording to sequencer now functions effortless with notes landing on the correct step. 
Also no more double triggering of notes while recording.

midi_devices.hpp

@@ -83,10 +83,10 @@ void MD_sendControlChange(uint8_t channel, uint8_t cc, uint8_t value);
 #ifdef MIDI_DEVICE_DIN
 void handleNoteOn_MIDI_DEVICE_DIN(byte inChannel, byte inNumber, byte inVelocity)
 {
-  handleNoteOn(inChannel, inNumber, inVelocity);
   seq_note_in=inNumber;
   seq_note_in_velocity=inVelocity;
-#ifdef DEBUG
+  handleNoteOn(inChannel, inNumber, inVelocity);
+  #ifdef DEBUG
   Serial.print(F("[MIDI_DIN] NoteOn"));
 #endif
   if (configuration.sys.soft_midi_thru == 1)
@@ -584,9 +584,9 @@ void handleSystemReset_MIDI_DEVICE_DIN(void)
 #ifdef MIDI_DEVICE_USB_HOST
 void handleNoteOn_MIDI_DEVICE_USB_HOST(byte inChannel, byte inNumber, byte inVelocity)
 {
-  handleNoteOn(inChannel, inNumber, inVelocity);
   seq_note_in=inNumber;
   seq_note_in_velocity=inVelocity;
+  handleNoteOn(inChannel, inNumber, inVelocity);
 #ifdef DEBUG
   Serial.print(F("[MIDI_USB_HOST] NoteOn"));
 #endif

sequencer.cpp

@@ -25,18 +25,13 @@ void sequencer_part1(void)
   //seq_note_in = 0;
   //}
 
-  //  if (LCDML.FUNC_getID() == LCDML.OTHER_getIDFromFunction(UI_func_sequencer)) {  //is in UI of Sequencer
+  //record to sequencer if sequencer menu is active and recording is active
-
+  if (seq_note_in > 0 && seq_recording == true  && LCDML.FUNC_getID() == LCDML.OTHER_getIDFromFunction(UI_func_sequencer)) {
-  //write to sequencer if in sequencer menu
+    seq_data[seq_active_track][seq_step] = seq_note_in;
-  //    if (seq_note_in > 0 && seq_recording == true) {
+    seq_vel[seq_active_track][seq_step] = seq_note_in_velocity;
-  //
+    seq_note_in = 0;
-  //      //  if (  seq_content_type[ seq_patternchain[seq_chain_active_step][active_track]  ] == 1) handleNoteOff(configuration.dexed[0].midi_channel, seq_data[active_track][seq_step] + seq_transpose , 0);
+    seq_note_in_velocity = 0;
-  //
+  }
-  //      seq_data[seq_active_track][seq_step] = seq_note_in;
-  //      seq_vel[seq_active_track][seq_step] = seq_note_in_velocity;
-  //      seq_note_in = 0;
-  //      seq_note_in_velocity = 0;
-  //    }
 
   for (uint8_t d = 0; d < 4; d++)
   {
@@ -68,8 +63,8 @@ void sequencer_part1(void)
           arp_step = 0;
           arp_counter = 0;
           arp_note = seq_data[ seq_patternchain[seq_chain_active_step][d] ][seq_step] + seq_transpose;
-          if (seq_vel[ seq_patternchain[seq_chain_active_step][d] ][seq_step]-200>=0)
+          if (seq_vel[ seq_patternchain[seq_chain_active_step][d] ][seq_step] - 200 >= 0)
-          arp_chord = seq_vel[ seq_patternchain[seq_chain_active_step][d] ][seq_step]-200;
+            arp_chord = seq_vel[ seq_patternchain[seq_chain_active_step][d] ][seq_step] - 200;
         }
       }
     }
@@ -77,7 +72,7 @@ void sequencer_part1(void)
     { //Arp
       if (arp_speed == 0 || (arp_speed == 1 && arp_counter == 0) ) {
 
-        if (arp_step % 8 ==0 ) {
+        if (arp_step % 8 == 0 ) {
           handleNoteOn(configuration.dexed[seq_chord_dexed_inst].midi_channel, arp_note + arp_octave * 12 , seq_chord_velocity);
           arp_note_prev = arp_note + arp_octave * 12;
         }
@@ -95,12 +90,10 @@ void sequencer_part1(void)
         }
       }
     }
-    
     seq_noteoffsent[d] = false;
   }
   arp_counter++;
   seq_step++;
-
   if (arp_speed == 0)  // Arp Speed 1/16
   {
     arp_step++;
@@ -138,7 +131,7 @@ void sequencer_part2(void)
 {
   for (uint8_t d = 0; d < 4; d++)
   {
-    if ( seq_noteoffsent[d] == false) {
+    if (seq_noteoffsent[d] == false) {
       if ( seq_prev_note[d] > 0 && seq_track_type[d] > 0)
       {
         handleNoteOff(configuration.dexed[seq_inst_dexed[d]].midi_channel, seq_prev_note[d] , 0);

sequencer.h

@@ -41,7 +41,7 @@ int seq_bpm = 102;
 uint8_t seq_temp_select_menu;
 uint8_t seq_temp_active_menu = 99;
 uint8_t seq_chain_active_chainstep;
-uint8_t seq_chain_lenght = 3; // 0 = 16 steps, 1 = 32 Steps, 2 = 46 Steps, 3 = 64 Steps
+uint8_t seq_chain_lenght = 0; // 0 = 16 steps, 1 = 32 Steps, 2 = 46 Steps, 3 = 64 Steps
 uint8_t seq_chain_active_step = 0;
 uint8_t seq_prev_note[4]; // note_offs for every (instr.) track
 uint8_t seq_prev_vel[4];
@@ -81,7 +81,7 @@ uint8_t seq_vel[10][16] = {120, 0, 0, 0, 120, 0, 0, 0, 120, 0, 0, 0, 120, 0, 0,
 uint8_t seq_patternchain[4][4] = { 0 , 1 , 6 , 9 , 0 , 1 , 5 , 8 , 0 , 1 , 6 , 9 , 2 , 1 , 5 , 7
                                  };
 uint8_t seq_content_type[10] = { 0, 0, 0, 0 , 1, 1, 1 , 1 , 1 , 1  }; // 0 = track is Drumtrack, 1= Instrumenttrack, 2= Chord or Arpeggio
-uint8_t seq_track_type[4] = { 0, 0, 3, 1 }; // 0 = track is Drumtrack, 1 = Instrumenttrack, 2 = Chord, 3 = Arp
+uint8_t seq_track_type[4] = { 0, 0, 0, 1 }; // 0 = track is Drumtrack, 1 = Instrumenttrack, 2 = Chord, 3 = Arp
 
 //uint8_t seq_reverb[4][16] = {0, 0,  0, 0, 0, 0,  0, 0, 0, 0,  0, 0, 0, 0,  0, 0,
 //                             0, 0,  0, 0, 15, 0,  0, 0, 0, 0,  0, 0, 36, 0,  0, 0,