From 65163a19d1bcfceb97d43791ef209c7d5de09641 Mon Sep 17 00:00:00 2001 From: MrDham Date: Tue, 20 Apr 2021 23:23:05 +0200 Subject: [PATCH 1/4] Update README.md --- README.md | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/README.md b/README.md index 0f3c799..0b52389 100644 --- a/README.md +++ b/README.md @@ -101,7 +101,9 @@ Let's consider a Fade-in / Picth Variation / Fade-out sequence (I use right hand 7. Rod antenna MIDI CC: 8 positions (None, 8-Balance, 10-Pan, 16-MSB/48-LSB-GeneralPurpose-1, 17-MSB/49-LSB-GeneralPurpose-2, 18-GeneralPurpose-3, 19-GeneralPurpose-4, 74-cutoff) - 14 Bit messages are sent in the following order: LSB (1st), MSB (2nd). + For 14 Bit CC messages, 2 bytes are always sent in the following order: MSB (1st), LSB (2nd) as per MIDI 1.0 Standard. + The receiver can bufferize MSB to synchronize it with the LSB. + 8. Loop antenna MIDI CC: 8 positions (1-Modulation, 7-Volume, 11-Expression, 71-Resonnance, 74-Cutoff, 91-Reverb, 93-Chorus, 95-Phaser) From 36e0e7dc620b4b6a5fe24d02263190763204b49a Mon Sep 17 00:00:00 2001 From: MrDham Date: Tue, 20 Apr 2021 23:28:49 +0200 Subject: [PATCH 2/4] Update README.md --- README.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/README.md b/README.md index 0b52389..934220b 100644 --- a/README.md +++ b/README.md @@ -101,7 +101,7 @@ Let's consider a Fade-in / Picth Variation / Fade-out sequence (I use right hand 7. Rod antenna MIDI CC: 8 positions (None, 8-Balance, 10-Pan, 16-MSB/48-LSB-GeneralPurpose-1, 17-MSB/49-LSB-GeneralPurpose-2, 18-GeneralPurpose-3, 19-GeneralPurpose-4, 74-cutoff) - For 14 Bit CC messages, 2 bytes are always sent in the following order: MSB (1st), LSB (2nd) as per MIDI 1.0 Standard. + For 14 Bit CC messages, MSB and LSB are always sent together and in the following order: MSB (1st), LSB (2nd) as per MIDI 1.0 Standard. The receiver can bufferize MSB to synchronize it with the LSB. 8. Loop antenna MIDI CC: 8 positions From 1108c54b2dc5508920c94e72c9adb29c52ffe2e8 Mon Sep 17 00:00:00 2001 From: MrDham Date: Tue, 20 Apr 2021 23:30:00 +0200 Subject: [PATCH 3/4] Add files via upload --- Open_Theremin_V3/application.cpp | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/Open_Theremin_V3/application.cpp b/Open_Theremin_V3/application.cpp index 4e288ec..f736349 100644 --- a/Open_Theremin_V3/application.cpp +++ b/Open_Theremin_V3/application.cpp @@ -542,6 +542,7 @@ void Application::midi_msg_send(uint8_t channel, uint8_t midi_cmd1, uint8_t midi // Calibrate pitch bend and other parameters accordingly to the receiver synth (see midi_calibrate). // New notes won't be generated as long as pitch bend will do the job. // The bigger is synth's pitch bend range the beter is the effect. +// If pitch bend range = 1 no picth bend is generated (portamento will do a better job) void Application::midi_application () { double delta_loop_cc_val = 0; @@ -600,11 +601,11 @@ void Application::midi_application () { if (rod_midi_cc != 255) { + midi_msg_send(midi_channel, 0xB0, rod_midi_cc, (uint8_t)(new_midi_rod_cc_val >> 7)); if (rod_midi_cc_lo != 255) { midi_msg_send(midi_channel, 0xB0, rod_midi_cc_lo, (uint8_t)(new_midi_rod_cc_val & 0x007F)); } - midi_msg_send(midi_channel, 0xB0, rod_midi_cc, (uint8_t)(new_midi_rod_cc_val >> 7)); } old_midi_rod_cc_val = new_midi_rod_cc_val; } @@ -668,11 +669,11 @@ void Application::midi_application () { if (rod_midi_cc != 255) { + midi_msg_send(midi_channel, 0xB0, rod_midi_cc, (uint8_t)(new_midi_rod_cc_val >> 7)); if (rod_midi_cc_lo != 255) { midi_msg_send(midi_channel, 0xB0, rod_midi_cc_lo, (uint8_t)(new_midi_rod_cc_val & 0x007F)); } - midi_msg_send(midi_channel, 0xB0, rod_midi_cc, (uint8_t)(new_midi_rod_cc_val >> 7)); } old_midi_rod_cc_val = new_midi_rod_cc_val; } From 4bd18d4d7b69702d89fcc7bdc75cc9059b3a6097 Mon Sep 17 00:00:00 2001 From: MrDham Date: Tue, 20 Apr 2021 23:33:51 +0200 Subject: [PATCH 4/4] Update application.cpp --- Open_Theremin_V3/application.cpp | 1 - 1 file changed, 1 deletion(-) diff --git a/Open_Theremin_V3/application.cpp b/Open_Theremin_V3/application.cpp index f736349..cd2b837 100644 --- a/Open_Theremin_V3/application.cpp +++ b/Open_Theremin_V3/application.cpp @@ -542,7 +542,6 @@ void Application::midi_msg_send(uint8_t channel, uint8_t midi_cmd1, uint8_t midi // Calibrate pitch bend and other parameters accordingly to the receiver synth (see midi_calibrate). // New notes won't be generated as long as pitch bend will do the job. // The bigger is synth's pitch bend range the beter is the effect. -// If pitch bend range = 1 no picth bend is generated (portamento will do a better job) void Application::midi_application () { double delta_loop_cc_val = 0;