Merge pull request #25 from MrDham/MrDham-More-CC-for-rod-anenna

Mr dham more cc for rod anenna

Open_Theremin_V3/application.cpp

@@ -919,19 +919,28 @@ void Application::set_parameters ()
         rod_midi_cc_lo = 255; // Nothing
         break; 
       case 1:
-      case 2:
         rod_midi_cc = 8; // Balance
-        rod_midi_cc_lo = 40; // Balance least significant bits
+        rod_midi_cc_lo = 255; // No least significant bits
+        break; 
+      case 2:
+        rod_midi_cc = 10; // Pan
+        rod_midi_cc_lo = 255; // No least significant bits
         break; 
       case 3:
+        rod_midi_cc = 16; // General Purpose 1 (14 Bits)
+        rod_midi_cc_lo = 48; // General Purpose 1 least significant bits
+        break; 
       case 4:
-        rod_midi_cc = 10; // Pan
+        rod_midi_cc = 17; // General Purpose 2 (14 Bits)
-        rod_midi_cc_lo = 42; // Pan least significant bits
+        rod_midi_cc_lo = 49; // General Purpose 2 least significant bits
         break; 
       case 5:
+        rod_midi_cc = 18; // General Purpose 3 (7 Bits)
+        rod_midi_cc_lo = 255; // No least significant bits
+        break; 
       case 6:
-        rod_midi_cc = 16; // Ribbon Controler
+        rod_midi_cc = 19; // General Purpose 4 (7 Bits)
-        rod_midi_cc_lo = 48; // Ribbon Controler least significant bits
+        rod_midi_cc_lo = 255; // No least significant bits
         break; 
       default:
         rod_midi_cc = 74; // Cutoff (exists of both loop and rod)

README.md

@@ -98,8 +98,10 @@ Let's consider a Fade-in / Picth Variation / Fade-out sequence (I use right hand
      For classical glissando and in order to have same note on audio and MIDI, use exactly same pitch bend range on your synth. 
      Maximum setting possible is recomended.
  6. Volume trigger / Velocity sensitivity (how fast moves the volume loop's hand): 128 positions (0 to 127)
- 7. Rod antenna MIDI CC: 5 positions 
+ 7. Rod antenna MIDI CC: 8 positions 
-    (None, 8-MSB/40-LSB-Balance, 10-MSB/42-LSB-Pan, 16-MSB/48-LSB-Ribbon controler, 74-cutoff) 14 Bit messages are sent in the following order: LSB (1st), MSB (2nd). 
+    (None, 8-Balance, 10-Pan, 16-MSB/48-LSB-GeneralPurpose-1, 17-MSB/49-LSB-GeneralPurpose-2, 18-GeneralPurpose-3, 19-GeneralPurpose-4, 74-cutoff) 
+    
+    14 Bit messages are sent in the following order: LSB (1st), MSB (2nd). 
  8. Loop antenna MIDI CC: 8 positions 
     (1-Modulation, 7-Volume, 11-Expression, 71-Resonnance, 74-Cutoff, 91-Reverb, 93-Chorus, 95-Phaser)