Fix for Issue #471 Ignore MIDI All Notes Off in Omni mode (#493)

Co-authored-by: probonopd <probonopd@users.noreply.github.com>
pull/494/head^2
Kevin 2 years ago committed by GitHub
parent af0420edfa
commit bb50d022f3
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
  1. 5
      src/mididevice.cpp

@ -324,7 +324,10 @@ void CMIDIDevice::MIDIMessageHandler (const u8 *pMessage, size_t nLength, unsign
break;
case MIDI_CC_ALL_NOTES_OFF:
if (!m_pConfig->GetIgnoreAllNotesOff ())
// As per "MIDI 1.0 Detailed Specification" v4.2
// From "ALL NOTES OFF" states:
// "Receivers should ignore an All Notes Off message while Omni is on (Modes 1 & 2)"
if (!m_pConfig->GetIgnoreAllNotesOff () && m_ChannelMap[nTG] != OmniMode)
{
m_pSynthesizer->notesOff (pMessage[2], nTG);
}

Loading…
Cancel
Save