Fixing LFO frequency on the FXEngine

src/fx_engine.hpp

@@ -69,12 +69,12 @@ class FxEngine : public FXBase
 public:
     typedef typename DataType<format>::T T;
 
-    FxEngine(float32_t sampling_rate) :
+    FxEngine(float32_t sampling_rate, float32_t max_lfo_frequency = 1.0f) :
         FXBase(sampling_rate)
     {
         this->buffer_ = new uint16_t[size];
-        this->lfo_[LFO_1] = new LFO(sampling_rate, LFO::Waveform::Sine, 0.0f, 32.0f);
+        this->lfo_[LFO_1] = new LFO(sampling_rate, LFO::Waveform::Sine, 0.0f, max_lfo_frequency);
-        this->lfo_[LFO_2] = new LFO(sampling_rate, LFO::Waveform::Sine, 0.0f, 32.0f);
+        this->lfo_[LFO_2] = new LFO(sampling_rate, LFO::Waveform::Sine, 0.0f, max_lfo_frequency);
         this->clear();
     }
 

src/fx_shimmer_reverb.cpp

@@ -10,8 +10,8 @@ ShimmerReverb::ShimmerReverb(float32_t sampling_rate) :
     FXElement(sampling_rate),
     engine_(sampling_rate)
 {
-    this->engine_.setLFOFrequency(LFO_1, 0.5f / sampling_rate);
+    this->engine_.setLFOFrequency(LFO_1, 0.5f);
-    this->engine_.setLFOFrequency(LFO_2, 0.3f / sampling_rate);
+    this->engine_.setLFOFrequency(LFO_2, 0.3f);
     this->setInputGain(1.0f);
     this->setLP(0.7f);
     this->setDiffusion(0.625f);

src/performance.ini

@@ -307,7 +307,7 @@ FXChainPhaserEnable=0
 FXChainPhaserWet=50
 FXChainPhaserRate=5
 FXChainPhaserResonance=45
-FXChainTapeDelayEnable=1
+FXChainTapeDelayEnable=0
 FXChainTapeDelayWet=50
 FXChainTapeDelayLeftDelayTime=15
 FXChainTapeDelayRightDelayTime=22
@@ -315,7 +315,7 @@ FXChainTapeDelayFlutter=0
 FXChainTapeDelayFeedback=35
 FXChainShimmerReverbEnable=1
 FXChainShimmerReverbWet=70
-FXChainShimmerReverbInputGain=45
+FXChainShimmerReverbInputGain=55
-FXChainShimmerReverbTime=89
+FXChainShimmerReverbTime=75
 FXChainShimmerReverbDiffusion=75
 FXChainShimmerReverbLP=80

src/test/fxrack_test.cpp

@@ -190,6 +190,11 @@ int main()
     rack->getTube()->setOverdrive(1.0f);
 
     rack->getChorus()->setEnable(false);
+    rack->getChorus()->setWetLevel(0.5f);
+    rack->getChorus()->setRate(0.2f);
+    rack->getChorus()->setDepth(0.15f);
+    rack->getChorus()->setFeedback(0.15f);
+    
     rack->getPhaser()->setEnable(false);
 
     rack->getOrbitone()->setEnable(false);