From 1199230c73d023a2e90ba077dc2bf08b2735ebb8 Mon Sep 17 00:00:00 2001
From: probonopd <probonopd@users.noreply.github.com>
Date: Tue, 29 Apr 2025 08:09:55 +0200
Subject: [PATCH] BREAKING CHANGE: Load default performances from
performance/001_Default (#895)
BREAKING CHANGE: Load default performances from performance/001_Default
rather than performance/
Closes #893, #894
---
src/performanceconfig.cpp | 16 +---------------
1 file changed, 1 insertion(+), 15 deletions(-)
diff --git a/src/performanceconfig.cpp b/src/performanceconfig.cpp
index d0ce2de..dfff8a9 100644
--- a/src/performanceconfig.cpp
+++ b/src/performanceconfig.cpp
@@ -33,7 +33,6 @@ LOGMODULE ("Performance");
#define PERFORMANCE_DIR "performance"
#define DEFAULT_PERFORMANCE_FILENAME "performance.ini"
#define DEFAULT_PERFORMANCE_NAME "Default"
-#define DEFAULT_PERFORMANCE_BANK_NAME "Default"
CPerformanceConfig::CPerformanceConfig (FATFS *pFileSystem)
: m_Properties (DEFAULT_PERFORMANCE_FILENAME, pFileSystem)
@@ -1168,10 +1167,6 @@ bool CPerformanceConfig::ListPerformanceBanks()
}
unsigned nNumBanks = 0;
-
- // Add in the default performance directory as the first bank
- m_PerformanceBankName[0] = DEFAULT_PERFORMANCE_BANK_NAME;
- nNumBanks = 1;
m_nLastPerformanceBank = 0;
// List directories with names in format 01_Perf Bank Name
@@ -1277,10 +1272,7 @@ std::string CPerformanceConfig::GetPerformanceBankName(unsigned nBankID)
{
return m_PerformanceBankName[nBankID];
}
- else
- {
- return DEFAULT_PERFORMANCE_BANK_NAME;
- }
+ return "";
}
std::string CPerformanceConfig::AddPerformanceBankDirName(unsigned nBankID)
@@ -1290,12 +1282,6 @@ std::string CPerformanceConfig::AddPerformanceBankDirName(unsigned nBankID)
{
// Performance Banks directories in format "001_Bank Name"
std::string Index;
- if (nBankID == 0)
- {
- // Legacy: Bank 1 is the default performance directory
- return "";
- }
-
if (nBankID < 9)
{
Index = "00" + std::to_string(nBankID+1);