Fixes for modulated delay feedback.

master
Holger Wirtz 5 years ago
parent 0521b5d839
commit a0cca8375d
  1. 10
      MicroMDAEPiano.ino
  2. 6
      UI.hpp
  3. 2
      config.h

@ -248,12 +248,10 @@ void setup()
#endif #endif
modchorus_r.offset(15.0); modchorus_r.offset(15.0);
modchorus_l.offset(15.0); modchorus_l.offset(15.0);
//modchorus_r.feedback(0.25); modchorus_fbk_mixer_r.gain(0, 1.0);
//modchorus_l.feedback(0.25); modchorus_fbk_mixer_l.gain(0, 1.0);
modchorus_fbk_mixer_r.gain(0, 0.75); modchorus_fbk_mixer_r.gain(1, 0.0);
modchorus_fbk_mixer_l.gain(0, 0.75); modchorus_fbk_mixer_l.gain(1, 0.0);
modchorus_fbk_mixer_r.gain(1, 0.25);
modchorus_fbk_mixer_l.gain(1, 0.25);
// internal mixing of original signal(0), reverb(1) and chorus(2) // internal mixing of original signal(0), reverb(1) and chorus(2)
mixer_r.gain(VOL_MAIN, 0.5); mixer_r.gain(VOL_MAIN, 0.5);

@ -2208,11 +2208,7 @@ void set_chorus_feedback(uint8_t value)
Serial.print(F("Set CHORUS_FEEDBACK ")); Serial.print(F("Set CHORUS_FEEDBACK "));
Serial.println(value); Serial.println(value);
#endif #endif
//modchorus_r.feedback(mapfloat(float(value), ENC_CHORUS_FEEDBACK_MIN, ENC_CHORUS_FEEDBACK_MAX, 0.0, 1.0)); float tmp = mapfloat(float(value), ENC_CHORUS_FEEDBACK_MIN, ENC_CHORUS_FEEDBACK_MAX, 0.0, 0.2);
//modchorus_l.feedback(mapfloat(float(value), ENC_CHORUS_FEEDBACK_MIN, ENC_CHORUS_FEEDBACK_MAX, 0.0, 1.0));
float tmp = mapfloat(float(value), ENC_CHORUS_FEEDBACK_MIN, ENC_CHORUS_FEEDBACK_MAX, 0.0, 0.5);
modchorus_fbk_mixer_r.gain(0, 1.0 - tmp);
modchorus_fbk_mixer_l.gain(0, 1.0 - tmp);
modchorus_fbk_mixer_r.gain(1, tmp); modchorus_fbk_mixer_r.gain(1, tmp);
modchorus_fbk_mixer_l.gain(1, tmp); modchorus_fbk_mixer_l.gain(1, tmp);
configuration.chorus_feedback = value; configuration.chorus_feedback = value;

@ -243,7 +243,7 @@
#define ENC_CHORUS_INTENSITY_DEFAULT 50 #define ENC_CHORUS_INTENSITY_DEFAULT 50
// //
#define ENC_CHORUS_FEEDBACK_MIN 0 #define ENC_CHORUS_FEEDBACK_MIN 0
#define ENC_CHORUS_FEEDBACK_MAX 10 #define ENC_CHORUS_FEEDBACK_MAX 20
#define ENC_CHORUS_FEEDBACK_DEFAULT 0 #define ENC_CHORUS_FEEDBACK_DEFAULT 0
// //
#define ENC_CHORUS_WAVEFORM_MIN 1 #define ENC_CHORUS_WAVEFORM_MIN 1

Loading…
Cancel
Save