From 4b1e37af5ec1a39e107b260f64282a3fb04b23f7 Mon Sep 17 00:00:00 2001
From: Kevin <68612569+diyelectromusic@users.noreply.github.com>
Date: Fri, 13 Dec 2024 22:29:30 +0000
Subject: [PATCH] Ignore last comment about MIDI dump, this is the right code, 
                                                                              
                                                                              
   it just isn't very responsive, so switched to print to stderr which flushes
 buffer immediately.

---
 src/mididevice.cpp | 20 +++++++++-----------
 1 file changed, 9 insertions(+), 11 deletions(-)

diff --git a/src/mididevice.cpp b/src/mididevice.cpp
index 334d191..216b466 100644
--- a/src/mididevice.cpp
+++ b/src/mididevice.cpp
@@ -136,8 +136,6 @@ void CMIDIDevice::MIDIMessageHandler (const u8 *pMessage, size_t nLength, unsign
 	// The packet contents are just normal MIDI data - see
 	// https://www.midi.org/specifications/item/table-1-summary-of-midi-message
 
-	// Additional byte-level MIDI dump for extra debugging
-/*
 	if (m_pConfig->GetMIDIDumpEnabled ())
 	{
 		switch (nLength)
@@ -146,40 +144,40 @@ void CMIDIDevice::MIDIMessageHandler (const u8 *pMessage, size_t nLength, unsign
 			if (   pMessage[0] != MIDI_TIMING_CLOCK
 			    && pMessage[0] != MIDI_ACTIVE_SENSING)
 			{
-				printf ("MIDI%u: %02X\n", nCable, (unsigned) pMessage[0]);
+				fprintf (stderr, "MIDI%u: %02X\n", nCable, (unsigned) pMessage[0]);
 			}
 			break;
 
 		case 2:
-			printf ("MIDI%u: %02X %02X\n", nCable,
+			fprintf (stderr, "MIDI%u: %02X %02X\n", nCable,
 				(unsigned) pMessage[0], (unsigned) pMessage[1]);
 			break;
 
 		case 3:
-			printf ("MIDI%u: %02X %02X %02X\n", nCable,
+			fprintf (stderr, "MIDI%u: %02X %02X %02X\n", nCable,
 				(unsigned) pMessage[0], (unsigned) pMessage[1],
 				(unsigned) pMessage[2]);
 			break;
+				
 		default:
 			switch(pMessage[0])
 			{
 				case MIDI_SYSTEM_EXCLUSIVE_BEGIN:
-					printf("MIDI%u: SysEx data length: [%d]:",nCable, uint16_t(nLength));
+					fprintf(stderr, "MIDI%u: SysEx data length: [%d]:",nCable, uint16_t(nLength));
 					for (uint16_t i = 0; i < nLength; i++)
 					{
 						if((i % 16) == 0)
-							printf("\n%04d:",i);
-						printf(" 0x%02x",pMessage[i]);
+							fprintf(stderr, "\n%04d:",i);
+						fprintf(stderr, " 0x%02x",pMessage[i]);
 					}
-					printf("\n");
+					fprintf(stderr, "\n");
 					break;
 				default:
-					printf("MIDI%u: Unhandled MIDI event type %0x02x\n",nCable,pMessage[0]);
+					fprintf(stderr, "MIDI%u: Unhandled MIDI event type %0x02x\n",nCable,pMessage[0]);
 			}
 			break;
 		}
 	}
-*/
 
 	// Only for debugging:
 /*