Fix shift overflow bug in ++ and -- (#85)

3 years ago · d8c2300585
parent 892df22ee8
commit d8c2300585
2 changed files with 4 additions and 4 deletions
--- a/src/FixedPoints/SFixedMemberFunctions.h
+++ b/src/FixedPoints/SFixedMemberFunctions.h
@ -221,14 +221,14 @@ constexpr SFixed<Integer, Fraction> SFixed<Integer, Fraction>::operator -() cons
 template< unsigned Integer, unsigned Fraction >
 SFixed<Integer, Fraction> & SFixed<Integer, Fraction>::operator ++()
 {
-	this->value += (1 << FractionSize);
+	this->value += (static_cast<InternalType>(1) << FractionSize);
 	return *this;
 }

 template< unsigned Integer, unsigned Fraction >
 SFixed<Integer, Fraction> & SFixed<Integer, Fraction>::operator --()
 {
-	this->value -= (1 << FractionSize);
+	this->value -= (static_cast<InternalType>(1) << FractionSize);
 	return *this;
 }

--- a/src/FixedPoints/UFixedMemberFunctions.h
+++ b/src/FixedPoints/UFixedMemberFunctions.h
@ -206,14 +206,14 @@ constexpr UFixed<Integer, Fraction> UFixed<Integer, Fraction>::fromInternal(cons
 template< unsigned Integer, unsigned Fraction >
 UFixed<Integer, Fraction> & UFixed<Integer, Fraction>::operator ++()
 {
-	this->value += (1 << FractionSize);
+	this->value += (static_cast<InternalType>(1) << FractionSize);
 	return *this;
 }

 template< unsigned Integer, unsigned Fraction >
 UFixed<Integer, Fraction> & UFixed<Integer, Fraction>::operator --()
 {
-	this->value -= (1 << FractionSize);
+	this->value -= (static_cast<InternalType>(1) << FractionSize);
 	return *this;
 }